#16275: Hom: introduce a check argument to simplify the unpickling detection 
logic
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  categories         |   Resolution:
       Keywords:  homset, pickling   |    Merged in:
        Authors:  Nicolas M. ThiƩry  |    Reviewers:  Simon King
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/SimonKing/ticket/16275           |  76bdaa90610e20d51456db092883ff7c61e5d6c2
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Sorry for the branch mess ...

 It's a bit convoluted, but I don't have a good alternative to support
 those pickles, so that's ok.

 Maybe we could save on the catching of exceptions upon building the error
 message? In principle,
 there should be no error message upon unpickling; and otherwise, the input
 is supposed to be properly initialized, and in particular should have a
 working repr, shouldn't it?

 Do you mind adding a few comments in the code, say a pointer to the
 discussion here + mention of the pickle added in the pickle jar? (or I can
 do it).

 In any cases, thanks much!

 Cheers,
                              Nicolas

--
Ticket URL: <http://trac.sagemath.org/ticket/16275#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to