#16277: MOLS constructions rom the Handbook of Combinatorial Designs
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/ncohen/16277 | Commit:
Dependencies: #16248, #16231, | d4f445b189ad16b28a436d9fd2fe82db53ebf3b1
#16269, #16058 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hi Nathann,
Globally looks good. Documentation builds and all test pass.
1) Could we make it go after #16272? There is a moderately trivial rebase
to do. I think it would be easier in that direction.
2) Could we also move the `TD_6_12` into the database module?
3) In the doctests of database, I would rather call directly the function
themselves followed by `is_transversal_design`. We have no idea (at least
me) that the corresponding design is actually returned when we call
`designs.orthogonal_array` with the good parameters. Nevertheless it is a
good test to check that the latter actually return a value for those
parameters (and to see whether or not it is the corresponding value).
4) (semi-stupid remark) For the 6 construction of OA from Vmt, the
function is rather trivial. One way to avoid duplication is to modify the
dictionnary into `n -> (k, constructor, extra_args)`. For the Vmt the
entries would look like
{{{
OA_constructions = {
...
46: (6, OA_from_Vmt, (4,9,[0, 1, 3, 2, 8])),
50: (8, OA_from_Vmt, (6,7,[0, 1, 3, 16, 35, 26, 36])),
...
}
}}}
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16277#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
