#16277: MOLS constructions rom the Handbook of Combinatorial Designs
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nathann Cohen      |    Reviewers:  Vincent Delecroix
Report Upstream:  N/A                |  Work issues:
         Branch:  u/ncohen/16277     |       Commit:
   Dependencies:  #16248, #16231,    |  7570b39787b8e11f64317ed11f4d5c282752ac74
  #16269, #16058                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * reviewer:   => Vincent Delecroix


Comment:

 Hi Nathann,

 In `orthogonal_arrays.py` in the function `transversal_design` you added a
 test
 {{{
 `TD(6,12)` ::

     sage: _ = designs.transversal_design(6,12)
 }}}
 which is actually already tested in the block above it '''and''' in
 `database.py`. So if you don't mind, you can simply remove it.

 Otherwise, everything is fine and it could go to positive review after
 that!

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16277#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to