#10963: Axioms and more functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton, Darij Grinberg, Travis
Branch: | Scrimshaw
public/ticket/10963-doc- | Work issues: To be merged
distributive | simultaneously with #15801
Dependencies: #11224, #8327, | Commit:
#10193, #12895, #14516, #14722, | 8da7522b983fd9a5bdc3680615e6a4b2094bab10
#13589, #14471, #15069, #15094, | Stopgaps:
#11688, #13394, #15150, #15506, |
#15757, #15759, #16244, #16269 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:775 nthiery]:
> - Deeply nested classes are not properly supported by Sphinx (waiting
> for #9107 which is basically done)
I thought #9107 is ''causing'' a problem with the (pdf) docs?
> There is just one little change I would prefer to revert:
> {{{
> - # This really should be in Category_over_base_ring.example,
> - # but that would mean duplicating the documentation above.
> - from category_types import Category_over_base_ring
> - if isinstance(self, Category_over_base_ring): # Huh, smelly Run
Time Type Checking, isn't it?
> - if "base_ring" not in keywords:
> - keywords["base_ring"]=self.base_ring()
> + if "base_ring" not in keywords:
> + try:
> + keywords["base_ring"] = self.base_ring()
> + except AttributeError:
> + pass
> }}}
>
> Indeed, I find that the duck typing here smells as much as before (in
> both cases, it points out that, in proper OO, this ought to be handled
> by Category_over_base_ring). And at least the RTTC and the comment are
> explicit about this smell.
>
> Simon, are you ok with that? No big deal anyway.
OK. Probably I will re-revert it (or do it properly) in #16296, though
`:-P`
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:783>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
