#16320: Handle finite slices for infinite enumerate sets
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: infinite | Merged in:
enumerated set slices | Reviewers: Nathann Cohen
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5771f94439336652610ac23848d4f2b24ef4858a
public/infinite_enum_set_slices-16320| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Hellooooooo Travis !!
Okay, this looks very cool but I have two questions:
1) Right now, if an infinite enumerated sets wants to implement
`__getitem__` differently (as unrank can be VERY slow) then the slicing
feature will be overwritten. Is there a way to avoid that ?
2) To me, computing the slice [:15] should call `__iter__`, which may have
been overwritten too. What d you think ?
Those are probems I see with how this is implemented in your branch, but I
do not know how to make it better, so I just ask. I am running all tests
right now, and if they pass this branch can be set to `positive_review` if
we cannot solve any of the problems above `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16320#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
