#15280: Extensions of PALP normal form, affine normal form and isomorphisms
-------------------------------------+-------------------------------------
Reporter: jkeitel | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: geometry | Resolution:
Keywords: toric | Merged in:
Authors: Jan Keitel | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jkeitel/normal_form_codimension | 4e8dace1658e2565a2f391e1528083d0c277235c
Dependencies: #13525 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by novoselt):
Inspired by Nathan / Volker arguments about filters for cached functions:
I didn't quite liked how `normal_form` was changed in #13525 to accept
parameters that make it return different output types. It used to be
straightforward
{{{
@cached_method
normal_form(self)
}}}
and with this ticket it gets more and more complicated, which makes it
unclear how (and whether) it should be cached. I also found it annoying
that this conditional output propagates down to helper functions.
So how about this:
- Drop arguments to helper functions so that their output is stable and if
something has to be done to it, the caller does not have to parse argument
to decompose and recompose the output appropriately. Am I right that
permutation/transformation don't cost much time to compute in addition to
normal form? Certainly permutations are trivial when read from the PALP
output.
- Perhaps only the default-algorithm normal form has to be cached: with
all the associated data, but only once and during each call `normal_form`
will drop unnecessary pieces?
Another option is to make `normal_form` always return everything, but
given the name I think `normal_form()` should return just the normal form
and nothing else or it gets confusing. Besides, while I agree that it is
nice to have extra data, I used normal form a lot by itself, so it is
useful on its own.
--
Ticket URL: <http://trac.sagemath.org/ticket/15280#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
