#16371: Change some integer divisions from / to //
-------------------------------------+-------------------------------------
Reporter: aapitzsch | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: misc | Resolution:
Keywords: python3 | Merged in:
Authors: André Apitzsch | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/aapitzsch/ticket/16371 | 83324d7298548555ef6547bca4e7501c29365fdc
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by wluebbe):
Hi André,
I did a {{{./sage -tp 4 --all --long >logs/sage-tp4-all-long-16371}}} and
got no failures :-). Now I will look at all the 63 changed modules (since
I am concerned that Sage has not enough (doc)tests).
I had run the doctest with the "-3" command line option (with mixed
success). I attach part of the results as they are related to
//division//. There is a pretty large overlap with your changes, but there
is not a complete match!
Therefor I am curious: How did you find / determine the {{{/}}} that you
changed into {{{//}}}?
I also tried to estimate how complete your patch might be. I ran
{{{futurize -w -f division src/sage}}} that inserted {{{form __future__
import division}}} into 401 py module. I compared the test results from
your patch vs. the current develop branch:
||Aspect ||develop / 16371||develop + division ||16471 + division ||
||runtime [sec] ||2,573 ||7,870 ||3,435 ||
||failures ||0 ||8,776 ||2,820 ||
||log lines ||5,090 ||72,581 ||24,198,439 ||
So this this is already quite a progress :-)
--
Ticket URL: <http://trac.sagemath.org/ticket/16371#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
