#16371: Change some integer divisions from / to //
-------------------------------------+-------------------------------------
Reporter: aapitzsch | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: misc | Resolution:
Keywords: python3 | Merged in:
Authors: André Apitzsch | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/aapitzsch/ticket/16371 | 83324d7298548555ef6547bca4e7501c29365fdc
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by wluebbe):
Hi,
I've reviewed the 63 modules and it looked OK :-)
Then I tried to find MORE division to change. [[br]]
That resulted in patch {{{u/wluebbe/ticket/16371}}}. The patch tested with
no failures. But then I inserted the {{{from __future__ import division}}}
and run the tests again. I was hoping for an improvement, but the result
is actually worse :-(( (see the last column in the table compared with
the previous column).
||Aspect ||develop / 16371||develop + division ||16471 + division
||develop + MORE + division ||
||runtime [sec] ||2,573 ||7,870 ||3,435 ||3,603 ||
||failures ||0 ||8,776 ||2,820 ||3,065 ||
||log lines ||5,090 ||24,198,439 ||72,581 ||74,464 ||
So I did not put my branch into this ticket! [[br]]
Can you see why the branch {{{u/wluebbe/ticket/16371}}} did not result in
visible progress? Or is the measurement misleading? [[br]]
How to make progress and when do we know when we are done??
--
Ticket URL: <http://trac.sagemath.org/ticket/16371#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
