#16083: MCQD to compute max cliques
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | ad90443749baad49c5b0e0919b7fed13cf2324cc
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/mcqd |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by azi):
Nathann,
as promised here are my comments !
1. I was not able to test the code since I cannot figure out how to
install the module. What am I supposed to do with the tar.bz2?
2. Following are some comments about the code/politics:
2.1. The program mcqd consists of a single .h file. Since the author of
the code agrees that we can use the program in Sage, is there any reason
not to simply put this .h file along with the .pyx module? This way we can
also tweak the file a bit (I'd like to remove debug stuff and unnecessary
verbosity counters that are present in the code)
2.2 (mcqd.pyx) The variable c0 is a pointer to c. Hence I am wondering,
why do you need to allocate memory ? On line 39 you assign the ptr c to it
and lose the reference to the allocated space.
2.3 (mcqd.pyx) Lines 30-37. Can they be made shorter by using the fact
(is it true ????) that sage_free(NULL) is legal?
2.4 (mcqd.pyx) Can we get rid of the memset by using sage_calloc on c?
2.5 (mcqd.pyx) At the very end C should be deleted.
--
Ticket URL: <http://trac.sagemath.org/ticket/16083#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
