#16083: MCQD to compute max cliques
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | ad90443749baad49c5b0e0919b7fed13cf2324cc
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/mcqd |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Yoooooooooooo !
> 1. I was not able to test the code since I cannot figure out how to
install the module. What am I supposed to do with the tar.bz2?
Save it in SAGE_ROOT/upstream/ and run "sage -f mcqd" (on the right
branch)
> 2.1. The program mcqd consists of a single .h file. Since the author
of the code agrees that we can use the program in Sage, is there any
reason not to simply put this .h file along with the .pyx module?
Yes : the code has not been reviewed. And it "may" be updated, which is
why we try not to change third-party code.
> 2.2 (mcqd.pyx) The variable c0 is a pointer to c.
?... No, it is not `O_o`
c0 is a pointer to `n*n` booleans.
> 2.3 (mcqd.pyx) Lines 30-37. Can they be made shorter by using the
fact (is it true ????) that sage_free(NULL) is legal?
Right. Done
> 2.4 (mcqd.pyx) Can we get rid of the memset by using sage_calloc on
c?
Done.
> 2.5 (mcqd.pyx) At the very end C should be deleted.
Why ? This is done automatically, isn't it ? You don't have to dealloc
objects when nothing else points toward them.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16083#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
