#16323: Construction of BIBD with k=5
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16323 | 07a31304b9d48ef6e07f1dd96c1d3185b8fafc95
Dependencies: #16279 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hi Nathann,
I did the correction. Furthermore, there was a typo in the main BIBD (a
`n` was used instead of a `v`).
Now that I read more carefully the code:
- why the construction using PBD can not be used from the main BIBD
function? In particular, considering organization, I would like to see the
functions `BIBD_from_PBD`, `_check_PBD`, `_relabel_BIBD`,
`PBD_4_5_8_9_12`, `_PBD_4_5_8_9_12_closure`, `PBD_from_TD` much higher in
the file, i.e. neither in the part "(v,4,1)-BIBD" nor in the part
"(v,5,1)-BIBD".
- More generally, the functions `steiner_triple_system`, `v_4_1_BIBD` and
`v_5_1_BIBD` currently follow various proofs. But we only care about
constructing the BIBD and not checking the proofs, doesn't we? We
certainly "check" the proof in the doctests but wouldn't it be possible to
write in the main BIBD:
{{{
if database.BIBD[v,k]:
...
elif construction1(v,k,existence=True):
...
elif construction2(v,k,existence=True):
...
}}}
and getting rid of `steiner_triple_system`, `v_4_1_BIBD` and
`v_5_1_BIBD`? I understand that it would be a dramatical change, so do not
answer considering it as a task for that ticket.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16323#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
