#15820: Implement sequences of bounded integers
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: algebra | Resolution:
Keywords: sequence bounded | Merged in:
integer | Reviewers:
Authors: Simon King | Work issues: Fix flakyness in
Report Upstream: N/A | adding sequences
Branch: | Commit:
u/SimonKing/ticket/15820 | 735939e593c9c302ff42c4973cbfe2e48eb22644
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* status: needs_review => needs_work
* work_issues: Use mpn_* for speedup of iteration and item access => Fix
flakyness in adding sequences
Comment:
I found failures in ''some'' runs:
{{{
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-10-7f6bcfa0.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
**********************************************************************
File "src/sage/misc/bounded_integer_sequences.pyx", line 1059, in
sage.misc.bounded_integer_sequences.BoundedIntegerSequence.__add__
Failed example:
S+T
Expected:
<4, 1, 6, 2, 7, 20, 9, 4, 1, 6, 2, 8, 15>
Got:
<4, 1, 6, 2, 7, 20, 9, 4, 1, 6, 2, 8, 31>
**********************************************************************
1 item had failures:
1 of 10 in
sage.misc.bounded_integer_sequences.BoundedIntegerSequence.__add__
[178 tests, 1 failure, 0.79 s]
----------------------------------------------------------------------
sage -t src/sage/misc/bounded_integer_sequences.pyx # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-15-6cf37501.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
[178 tests, 0.78 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-20-d43d6691.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
**********************************************************************
File "src/sage/misc/bounded_integer_sequences.pyx", line 1061, in
sage.misc.bounded_integer_sequences.BoundedIntegerSequence.__add__
Failed example:
T+S
Expected:
<4, 1, 6, 2, 8, 15, 4, 1, 6, 2, 7, 20, 9>
Got:
<4, 1, 6, 2, 8, 15, 4, 1, 6, 2, 7, 20, 25>
**********************************************************************
1 item had failures:
1 of 10 in
sage.misc.bounded_integer_sequences.BoundedIntegerSequence.__add__
[178 tests, 1 failure, 0.78 s]
----------------------------------------------------------------------
sage -t src/sage/misc/bounded_integer_sequences.pyx # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-25-04f71350.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
[178 tests, 0.78 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-29-a2a81517.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
[178 tests, 0.79 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-33-e89cc5fe.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
[178 tests, 0.81 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
king@linux-etl7:~/Sage/git/sage> ./sage -t
src/sage/misc/bounded_integer_sequences.pyx
Running doctests with ID 2014-06-03-13-33-38-83426cf0.
Doctesting 1 file.
sage -t src/sage/misc/bounded_integer_sequences.pyx
[178 tests, 0.79 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.9 seconds
cpu time: 0.8 seconds
cumulative wall time: 0.8 seconds
}}}
My first guess is that this comes from using `sage_malloc` in some places,
i.e., I should zero the memory first.
--
Ticket URL: <http://trac.sagemath.org/ticket/15820#comment:72>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
