#15475: Reenable broken doctests in #15473 and #15476 when #10963 is merged
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: 10963, | Merged in:
categories, c3, coercion, | Reviewers:
transitivity, descent algebras, | Work issues:
symmetric functions | Commit:
Authors: | 702e7a19c9ec25f7af538fefb6fc7491a3adebd1
Report Upstream: N/A | Stopgaps:
Branch: |
public/categories/15475 |
Dependencies: #10963, #15473, |
#15476 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
* priority: minor => major
Comment:
Replying to [comment:23 SimonKing]:
> I have no time to look at the code now. But from the description at
#16532, it seems to be the case that the coercion `phi: A -> B` is
registered by `B.register_coercion(phi)` during creation of A, which would
be a misuse. It should either be registered as ''the unique'' coerce
embedding of A (if this makes sense) by `A.register_embedding(phi)` during
creation of A, or it should be registered by `B.register_coercion(phi)`
during creation of B (not A), or should not be registered at all, letting
`B._coerce_map_from_(A)` do the job.
I've changed it to use `_coerce_map_from_` as this was the most robust
with #15303 not being done (although I had to explicitly do the function
composition). Thanks for clarifying.
Darij, final review.
--
Ticket URL: <http://trac.sagemath.org/ticket/15475#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
