#16553: Clean IncidenceStructure
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen, | Work issues:
Vincent Delecroix | Commit:
Report Upstream: N/A | a5c4dbc9d1b77315d90dd3dd7a8ccea780f59ecf
Branch: public/16553 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
Vincent, it would be cool if you could say what you did in there, because
you do a thousand things at once and it is difficult to list them all
while reading the patch. You should have done several thematic commits.
First, why do you rename `BlockDesign` to `TDesign` ? A GDD is not exactly
a 2-design (although it's admittedly not far) so we will not be able to
use TDesign as a base class for our methods later.
Then, things like "return len(self.blocks())" is criminal as it requires
to build the whole list only to compute its lengths. Given that you are
writing methods of the very class you are allowed to use private
variables, you know ? `:-P`
You also seem to add methods and this should go into a different patch.
Really, it is very hard to understand what you do here from the diff file,
so it is not the place to ad new stuff that will have to be discussed.
You seem to remove classes without deprecation, like `BlockDesign`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16553#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
