#16553: Clean IncidenceStructure
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen, | Work issues:
Vincent Delecroix | Commit:
Report Upstream: N/A | a5c4dbc9d1b77315d90dd3dd7a8ccea780f59ecf
Branch: public/16553 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yo !
> I can do that. But I am not sure you want to know the real history of my
commits.
Not "the real history". That's why we create several patches for several
things, and that's why we can add several commits in the same ticket : so
that we may present the changes in a way that makes them easy to review.
You didn't want to see the real history of my design commits eithers `:-P`
> The definition of block design used in Sage is wrong. A block design is
a synonym for incidence structure (as it can be checked on wikipedia or
the Handbok of combinatorial designs). What was considered are t-designs
for which you have well defined parameters `t-(v,k,\lambda)`. It is a
particular case of block design. Hopefully right now there is only one
class and making `BlockDesign = IncidenceStructure` looks safe enough to
me.
Well, right now tdesign returns an incidence structure too. Okay, one
question : should we deprecate !BlockDesign in favor of
!IncidenceStructure ? Also, it seems weird to have an upper case T in
TDesign, given that this "t" is a variable.... What about tDesign ?
What I don't like about this is that we do not need a tDesign class at
all, so why would we create one ? We create classes for the wrong reason
and we have nothing to put in them.
> The only stuff I added is just to simplify the `is_t_design` function
(like `t_indices`, `replication_numbers`, etc).
I have never heard of "t indices" anywhere. Where did you find this
terminology ? It just seems to be the degree of a point, taken as a
hypergraph ...
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16553#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
