#16553: Clean IncidenceStructure
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen, | Work issues:
Vincent Delecroix | Commit:
Report Upstream: N/A | dffcc4a8118a8bc5d9dfa6c1ab1aabe7aaaaa25a
Branch: public/16553v2 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
about [comment:116]/[comment:97] and non-ordered stuff:
- one possibility: we can avoid sorting the ground set and consider
[0,1,2], and [2,0,1] as different sets. For blocks, we convert everything
to tuple of integers and it is fine for them to do the comparison. What do
you think?
about [comment:117]:
> - What about renaming `_point_index` to `_point_to_index` to make its
purpose clearer ?
no problem.
> - Should `block_sizes` return `map(len,self._blocks)` or wrap them in a
`set` ?
You are right, it is the way it was before. So I will put it back. And
just for fun, here is the verbatim old implementation:
{{{
def block_sizes(self):
self._block_sizes = map(len, self.blocks())
return self._block_sizes
}}}
> Too bad that it is not very easy to have everything work with a "copy"
argument `:-/`
All right: I can put it back, but assume that the user feed the object
with sorted tuples of tuples. It is not that complicated. Is that ok for
you? I would like it to not waste my time with the constructor.
Not for this ticket
- right now the structure are immutable but it would makes sense to have
mutable ones (that can be turn into immutable ones). For example,
removing/adding blocks that contain a given point is a useful operation...
--
Ticket URL: <http://trac.sagemath.org/ticket/16553#comment:118>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
