#16598: Useless new classes and a replacement for _check_pbd
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16598 | 3f8cebb0d68d7e7ae0e9c763e9bc78a1bdb847dd
Dependencies: #16553 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_info
Comment:
I got it for the automorphism group! Thanks. But your definition of gdd is
wrong: any pair of points is either in a group or in lambda blocks '''but
not both'''. And this is why the blocks completely determine the groups:
two points are in the same group if they are not in a block!
What do you think of having only one class (with blocks and groups) and
methods:
- `.is_t_design(self,t,v,k,l)`
- `.is_group_divisible_design(self,v,G,K,l)`
- `.is_partially_balanced_design(self,v,K,l)`
I do not like the fact of having one extra empty class whose only purpose
is a check at creation... Moreover, if we switch to mutable classes it
would be cool that after transformations we check the kind of thing we
obtain. The only thing that bother me a little bit is this `dual` method
which does not make any sense for groups (perhaps it does??).
Why do you not translate the groups over integers as it is the case for
blocks?
You really like to use tuple of tuples for groups and list of lists for
blocks (see comment:4 above)?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16598#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
