#16598: Useless new classes and a replacement for _check_pbd
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16598 | 1a5a4b8203a2ad104d617a150e2029dbe3a315b1
Dependencies: #16553 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hi Nathann,
I added a little commit of cleaning (and also replace the deepcopy by
something more explicit) at `u/vdelecroix/16598`.
The semantic of `copy=True/False` is currently not the same with
`.blocks()` and `.groups()`. I decided (and you did not complain) that
with `copy=False` it just returns a pointer to the attribute `._blocks`
which means something on the integers... whatever the ground set could be.
If you think it is bad, then we need to change it in `.blocks()` and
`.points()`. Otherwise, change it in `.groups()`.
In the function `is_group_divisible_design` it is assumed that the ground
set is `{0, ..., v-1}` (which is just find since it is called with the
internal data from `GroupDivisibleDesign`). It would be cool to specify it
in the doc...
What is the point of `matrix[i*n+j] != <unsigned short> -1` (in
`is_group_divisible_design`)?
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16598#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
