#14239: symbolic radical expression for algebraic number
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:  davidloeffler
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Marc Mezzarobba,   |    Reviewers:  Marc Mezzarobba
  Martin von Gagern                  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  16269faa29708fad205889d3063008772c036df5
  u/gagern/ticket/14239              |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by gagern):

 OK, I completly rewrite my approach. Due to #16651 I don't trust the
 conversion from !NumberField to !SymbolicRing. So I read the essence of
 what they are doing, and adapted it to my use. It works excellent in all
 the test cases I have gathered so far.

 However, I still have some trouble finding good test cases to cover all my
 code paths. I'm not sure whether you'd be willing to accept my patch
 without that kind of coverage. Here is what's missing:

 1. Some number where `to_poly_solve=False` won't find the solution but
 `to_poly_solve=True` will yield an exact solution.
 2. Some number where solve will not find all roots, or only some of these
 are exact.
 3. Some situation where we can demonstrate that multiple symbolic roots
 overlap the current value interval.

 For the third use case, the one where `len(candidates) == 1` fails, I just
 found an example: `AA(sqrt(2)*10^(-25)+3)`. I'll have to write some more
 code to ensure that it will in fact use the code path for which I designed
 it. Working on that.

--
Ticket URL: <http://trac.sagemath.org/ticket/14239#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to