#14239: symbolic radical expression for algebraic number
-------------------------------------+-------------------------------------
       Reporter:  gagern             |        Owner:  davidloeffler
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin von Gagern  |    Reviewers:  Marc Mezzarobba
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gagern/ticket/14239              |  e416116556a29c0b9304a5b7d5026f67b0e6ce3f
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by gagern):

 If there are any objections to the lack of tests for the
 `to_poly_solve=True` code path, then I'd be willing to take that out until
 someone can come up with an example to actually test that. If I simply
 replace the two-tuple by a one-tuple in the loop, that would be simple
 enough to restore later on. If I should remove all the code which is
 specific to `to_poly_solve=True`, then I'd like to back that up somewhere
 so it may be reactivated later on. Perhaps I'd do the removal as a
 separate commit which can be reverted if someone comes up with a case.

 By the way, the
 [http://maxima.sourceforge.net/docs/manual/en/maxima_78.html#IDX2788
 Maxima manual for to_poly_solve] didn't suggest some useful case either.
 Since the main benefit of `to_poly_solve` appears to be its ability to
 turn the equations into polynomials, it probably has little benefit over
 the standard solver.
 
[http://git.sagemath.org/sage.git/commit/?id=3278794b9a63e706b9ccef52435575a79f9a64ce
 3278794] from #6642 which introduced the use of `to_poly_solve=True` for
 `NumberFieldElement` doesn't contain any example of why it might be
 needed.

--
Ticket URL: <http://trac.sagemath.org/ticket/14239#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to