#16617: simple echelon matrix iterator
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.3
      Component:  linear algebra     |   Resolution:
       Keywords:  matrix             |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/16617                 |  f3cc9b7a9979e164565df53fa11dd6f8647a6ee9
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_info


Comment:

 Helloooooooooooo !

 First of all, I don't get why you wrote this in Cython instead of changing
 the old implementation... Does it change much to the performance ? I
 wonder if you wouldn't obtain the same crazy speedups simply caching `m0`
 as you do and using itertools instead of `VectorSpace`.. Or is it that you
 want to aviod the final matrix multiplication ?

 Details:

 - It seems that what you do is iterate on *reduced* echelon form

 - {{{number of columnes}}}

 - Could you add a doctest like that ?

 {{{
 sage: q=71
 sage: F = GF(q)
 sage: len(list(echelon_matrix_iterator(F, 1, 3, copy=False))) == q**2+q+1
 True
 sage: len(list(echelon_matrix_iterator(F, 2, 3, copy=False))) == q**2+q+1
 True
 }}}

 - I do not understand why you have to call {{{del}}} `O_o`

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16617#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to