#16617: simple echelon matrix iterator
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.3
Component: linear algebra | Resolution:
Keywords: matrix | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/16617 | 6908f39941ec6a4b79373400beb20c03824957cb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:10 ncohen]:
> {{{
> File "matrix/echelon_matrix.pyx", line 92, in
sage.matrix.echelon_matrix.echelon_matrix_iterator
> Failed example:
> all(a.is_immutable() and a.echelon_form() is a for a in it)
> Expected:
> True
> Got:
> False
> }}}
Seems that the code is not uniform among the matrices... for some
implementation the code of `.echelon_form` starts with
{{{
def echelon_form(self):
if self.fetch('in_echelon_form'): return self
}}}
but it seems to be not the case for matrices over finite field.
> Also, shouldn't the function be "reduced" echelon too ?
done.
Vincent
(PS: and after the follow up #16683, changing the implementation to use
gray code will dramatically improve the timings as we will avoid copying
the matrix `m0` over and over)
--
Ticket URL: <http://trac.sagemath.org/ticket/16617#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
