#16577: Make matrix.permute_rows and friends accept permutations of 0..n-1 now
that
we have them + misc improvements
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution:
Keywords: | Merged in:
Authors: Nicolas M. Thiéry | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nthiery/make_matrix_permute_rows_and_friends_accept_permutations_of_0__n_1_now_that_we_have_them___misc_improvements|
1eccf0163009c2280520a6e6be2f14ba3848422e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by kcrisman):
* As we discussed in person, there may be a few missing colons.
* Why gone?
{{{
- sage: sigma
- (1,2,3)(4,5)
}}}
I mean, it will be different, but this is helpful to the user to learn
how it works. Right now it's only in the warning which of course some
people will ignore ... because it's a warning. Actually, it looks like
you only do that once.
* I think this will probably break.
{{{
sage: G = PermutationGroup(['(1,2,3)', '(-1,0,1,2,3)'])
}}}
GAP doesn't complain when I ask for this group's order!
* Also, probably there is no point to SEEALSO the actual function in each
case. E.g. `permute_columns` should not SEEALSO itself.
* `swap_columns_c` test, if it's new, should probably be in the wrapper
`swap_columns`.
But actually this looks pretty good and straightforward.
--
Ticket URL: <http://trac.sagemath.org/ticket/16577#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
