#16577: Make matrix.permute_rows and friends accept permutations of 0..n-1 now 
that
we have them + misc improvements
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Nicolas M. ThiƩry  |    Reviewers:  Karl-Dieter Crisman
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/nthiery/make_matrix_permute_rows_and_friends_accept_permutations_of_0__n_1_now_that_we_have_them___misc_improvements|
  0434b5f9bce19e486198edf2cb130fd257fee130
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by nthiery):

 Replying to [comment:4 kcrisman]:
 > * Why gone?
 > {{{
 > -            sage: sigma
 > -            (1,2,3)(4,5)
 > }}}

 Oops, right; fixed, and made consistent over all tests.

 > * I think this will probably break.
 > {{{
 > sage: G = PermutationGroup(['(1,2,3)', '(-1,0,1,2,3)'])
 > }}}
 >   GAP doesn't complain when I ask for this group's order!

 The sanity checks are not changed by ticket, and it keeps on failing
 cleanly as before.

 > * Also, probably there is no point to SEEALSO the actual function in
 each case.  E.g. `permute_columns` should not SEEALSO itself.
 > * `swap_columns_c` test, if it's new, should probably be in the wrapper
 `swap_columns`.

 Oops, right!

--
Ticket URL: <http://trac.sagemath.org/ticket/16577#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to