#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution:
Keywords: flint, matrix | Merged in:
Authors: Marc Masdeu | Reviewers: William Stein
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmasdeu/ticket/16803 | 22e6896aadf0d6f99aeebc29041d6fd247569738
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by was):
Be more careful about freeing. Right now, in all cases, you do
{{{
sage_free(self._rows)
sage_free(self._entries)
}}}
You're depending on self._rows being automatically initialized to NULL
(?), and sage_free doing the right thing when passed NULL. Maybe that
works, but I would be more comfortable if it was explicit, e.g., put
self._rows=NULL and only free self._rows if not NULL (or check the source
code and see whether it already works that way).
--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
