#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.4
Component: linear algebra | Resolution:
Keywords: flint, matrix | Merged in:
Authors: Marc Masdeu | Reviewers: William Stein
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmasdeu/ticket/16803 | 70afcd6d8a4092515da48e2e33d7024a80c8ec8e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by was):
* status: needs_review => positive_review
Comment:
Replying to [comment:36 vbraun]:
> Its safe to call `sage_free` with `NULL`, but an unintialized pointer
can have a non-null value. You should explicitly set all pointers to NULL
in `__cinit__`.
Thanks for clarifying this. The change he made does explicitly set
pointers to NULL now, but it also checks for NULL before calling
sage_free. He should probably change that part back.
Anyway, positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
