#16803: Reimplement matrix_integer_dense using FLINT
-------------------------------------+-------------------------------------
       Reporter:  mmasdeu            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  linear algebra     |   Resolution:
       Keywords:  flint, matrix      |    Merged in:
        Authors:  Marc Masdeu        |    Reviewers:  William Stein
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mmasdeu/ticket/16803             |  22e6896aadf0d6f99aeebc29041d6fd247569738
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by mmasdeu):

 * status:  positive_review => needs_review
 * commit:  2e66cee05777a1565f8aa012730df777f798cb0f =>
     22e6896aadf0d6f99aeebc29041d6fd247569738
 * branch:  u/jdemeyer/ticket/16803 => u/mmasdeu/ticket/16803


Comment:

 I have just realized that (in a bad design choice) I was initializing
 allocating _rows and _entries for every single matrix created, which is
 not very efficient. Now it is only done when needed (i.e. when calling
 _init_linbox()). Changes are minimal, and I ran the tests (long version)
 in /matrix/ for safety, but I will resubmit for review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=22e6896aadf0d6f99aeebc29041d6fd247569738
 22e6896]||{{{Trac 16803: Initialize _rows and _entries only when needed
 (to save memory).}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16803#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to