#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 508d8193ea3d99dda90515bced36c8cd8e747224
public/game_theory/solve_matching_games-16331| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vinceknight):
Replying to [comment:78 tscrim]:
> I've made the following reviewer changes:
>
> - Speed/memory improvements to `solve`.
> - Output of `solve` doesn't wrap the players in a list.
> - Input to `MatchingGame` can be 2 arguments.
> - Added `__eq__` to `MatchingGame` so it pickles.
> - Made `MatchingGame` unhashable because it's mutable.
> - Made attributes of `MatchingGame` private.
> - Added a `suitors()` and `reviewers()` methods which return tuples.
> - Changed input to `Player` because they were unused.
> - Latex output.
> - Doc formatting.
These all look awesome: thanks!
>
> FYI - I also experimented with removing the `Player` class, but it
didn't sit right with me.
>
> I'm thinking we should rename `bipartite` to the more explicit
`bipartite_graph`. Do you agree?
I went ahead and changed this as I thought it sounded way better.
Thanks a lot Travis (very much appreciated). Karl, thanks again for
finding the time, please let me know if there's anything I can help with
(I should be pushing to #16954 hopefully by end of tomorrow if not
tonight).
(By the way I am completely confused as to how to push to trac using `git
push trac...`I seem to try a bunch of combinations of `HEAD:u/[stuff]`,
some times it doesn't go, sometimes it seems to push to something but who
knows where and sometimes it gets here... I've read the docs on this
multiple times but that doesn't seem to clarify things for me... Any tips?
<- This is probably not a question for trac).
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:81>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
