#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 8b106a26407c51cd7676e9a2c62d488ea2fbe776
public/game_theory/solve_matching_games-16331| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: aae25ce141378189f73400f771951139aef304b3 =>
8b106a26407c51cd7676e9a2c62d488ea2fbe776
* branch:
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_
=> public/game_theory/solve_matching_games-16331
Comment:
I've made the following reviewer changes:
- Speed/memory improvements to `solve`.
- Output of `solve` doesn't wrap the players in a list.
- Input to `MatchingGame` can be 2 arguments.
- Added `__eq__` to `MatchingGame` so it pickles.
- Made `MatchingGame` unhashable because it's mutable.
- Made attributes of `MatchingGame` private.
- Added a `suitors()` and `reviewers()` methods which return tuples.
- Changed input to `Player` because they were unused.
- Latex output.
- Doc formatting.
FYI - I also experimented with removing the `Player` class, but it didn't
sit right with me.
I'm thinking we should rename `bipartite` to the more explicit
`bipartite_graph`. Do you agree?
Karl, is there anything that you can see that needs to be addressed?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=600c4dbe6bc134bc76c385fbfa01bb7b507e0142
600c4db]||{{{Merge branch
'u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_'
of trac.sagemath.org:sage into
public/game_theory/solve_matching_games-16331}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f366ff31871acb8c5506d90af1edffe654ba72e5
f366ff3]||{{{Formatting and doctest changes. Changed latex output.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6bd64cafa166cdc3422b4303ef44ef03c16cc517
6bd64ca]||{{{Some cleanup and making all tests pass.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=69c0e619571ac1c5cfed40c5205d3a351be10238
69c0e61]||{{{Some more changes and improvements.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8b106a26407c51cd7676e9a2c62d488ea2fbe776
8b106a2]||{{{Reverted change __repr__ to _repr_.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:78>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
