#17030: Knot Theory as a part of GSoC 2014.
-------------------------------------+-------------------------------------
       Reporter:  amitjamadagni      |        Owner:  amitjamadagni
           Type:  task               |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:                     |    Reviewers:  Miguel Marco
        Authors:  Amit Jamadagni,    |  Work issues:
  Miguel Marco                       |       Commit:
Report Upstream:  N/A                |  e6e17c401b8b879cd041dafc120d3943b3f2dacb
         Branch:                     |     Stopgaps:
  u/amitjamadagni/knots              |
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Also please respect
 [http://www.sagemath.org/doc/developer/coding_basics.html#headings-of-
 sage-library-code-files] and add your new files to the reference manual
 (have a look at the files in `src/doc/en/reference` to see how that is
 done).

 Even better, change
 {{{
 pd_error = _pd_check_(input_)
 if pd_error == True:
     raise Exception("...")
 elif pd_error == False:
     foo
 }}}
 to
 {{{
 if not _pd_check(input):
     raise ValueError("...")

 foo
 }}}
 and change the last line of `def _pd_check_(pd):` to `return not
 pd_error`, since I would expect a "check" function to return `True` if the
 checking was successful. Also drop the trailing underscores.

--
Ticket URL: <http://trac.sagemath.org/ticket/17030#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to