#5280: [with patch, positive review] problem with a subposet coming from an
order_filter
---------------------------+------------------------------------------------
Reporter: jhpalmieri | Owner: somebody
Type: defect | Status: new
Priority: minor | Milestone: sage-combinat
Component: combinatorics | Keywords:
Reviewer: | Author: Franco Saliola
Merged: |
---------------------------+------------------------------------------------
Comment(by saliola):
Replying to [comment:10 rlm]:
> Franco,
>
> Thanks for the incredibly detailed explanation! The main reason I was
asking is that there is no indication why this is okay in the code itself.
Could you put a sentence or two, maybe just in a comment, explaining why
this is done? Maybe something like "When the user asks for `a<b`, rich
comparison is used, and this is implemented only to enable sorting." Also,
if the result of sorting isn't consistent (e.g. cmp(a,b) == cmp(b,a)),
this should be mentioned too, I think.
I'm attaching a patch with the docfixes, and that also implements the
{{{__ne__}}} method, which I must have forgot to define. (Unfortunately,
in
Python {{{__ne__}}} does not default to {{{!__eq__}}}.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5280#comment:11>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
