#5280: [with patch, positive review] problem with a subposet coming from an
order_filter
----------------------------------------+-----------------------------------
Reporter: jhpalmieri | Owner: somebody
Type: defect | Status: new
Priority: minor | Milestone: sage-combinat
Component: combinatorics | Keywords:
Reviewer: Mike Hansen, Robert Miller | Author: Franco Saliola
Merged: |
----------------------------------------+-----------------------------------
Comment(by nthiery):
Replying to [comment:10 rlm]:
> Franco,
>
> Thanks for the incredibly detailed explanation! The main reason I was
asking is that there is no indication why this is okay in the code itself.
Could you put a sentence or two, maybe just in a comment, explaining why
this is done? Maybe something like "When the user asks for `a<b`, rich
comparison is used, and this is implemented only to enable sorting." Also,
if the result of sorting isn't consistent (e.g. cmp(a,b) == cmp(b,a)),
this should be mentioned too, I think.
Thanks also! I am having similar problems in several other places. This
really should be though of once for all, and a systematic policy should be
set up for
all occurences of this issue. Actually, it would be best if this could be
solved once for all at a higher level (in Element)?
One fine point (which certainly does not jeopardize this patch): I would
feel better returning 0 for incomparable elements rather than +1.
Would you mind starting a discussion about this on sage-devel?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5280#comment:14>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
