#16970: Add new plantri spkg
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers:
Authors: Nico Van Cleemput | Work issues:
Report Upstream: N/A | Commit:
Branch: u/nvcleemp | d9367c56bd0edc28f18bdaa93de51948a622c0b7
/plantri-spkg | Stopgaps:
Dependencies: #16972 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
> I had a look at factoring out common code. The problem is that although
it looks like there is a lot of common code, the exact values that
determine a valid input are different for each case. Internally `plantri`
also uses separate logics for each case. If somebody sees a way to factor
out all this logic, then I am curious to hear it! :-)
Well I gave it a try because I really did not like to see the same lines
in different functions (like n<64, ...) but after having begun to do the
job, I am convinced that having all the logic in one function does not
make the code much clearer. Soooooo Well, you are right, let us keep it
like that !
Do you have anything left to do with the code or is it in `needs_review` ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16970#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
