#16970: Add new plantri spkg
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers: Nathann Cohen
Authors: Nico Van Cleemput | Work issues:
Report Upstream: N/A | Commit:
Branch: public/16970 | aa60bf0d85ff499085c2bd3062356579b24457a9
Dependencies: #16972 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* commit: d9367c56bd0edc28f18bdaa93de51948a622c0b7 =>
aa60bf0d85ff499085c2bd3062356579b24457a9
* branch: u/nvcleemp/plantri-spkg => public/16970
* reviewer: => Nathann Cohen
Comment:
Helloooooooooo !
Okay, I just spent some time re-re-re-reading your code, to get to the
very obvious conclusion that it is very very clean.
I added a small commit on top of yours that does simple things:
- Length of the lines in the SPKG.txt file
- All functions should begin with a short line describing their job
- Refactored several 'if'
- I never know what "between 1 and 5" means (strict or not ?) so I
replaced it with `\geq` and `\leq`.
- Added some missing `# optional - plantri` that would have made it break
on machines on which the package is not installed.
Very good work. Thank a lot !
Nathann
P.S. : If you agree with the new commit you can set the ticket to
`positive_review`
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=b572274fae6a846ab7f7439d5dc717e6ca7048cf
b572274]||{{{trac #16970: Merged with beta4}}}||
||[http://git.sagemath.org/sage.git/commit/?id=aa60bf0d85ff499085c2bd3062356579b24457a9
aa60bf0]||{{{trac #16970: review}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16970#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
