#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Travis Scrimshaw,  |    Reviewers:  Travis Scrimshaw,
  Anne Schilling                     |  Anne Schilling
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/poset/fix_equality-14019|  
b1eefd78cd65736b44153761b929de1c4387cb70
   Dependencies:                     |     Stopgaps:  #14185
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Travis Scrimshaw, Anne Schilling', 'oldvalue': 
u'Nathann Cohen'}):

 * status:  needs_info => needs_review
 * author:  Nathann Cohen => Travis Scrimshaw, Anne Schilling
 * branch:  u/andrew.mathas/ticket/14019 =>
     public/combinat/poset/fix_equality-14019
 * commit:  d10a6efa75561632cdc76b2c98c5eca4312372ec =>
     b1eefd78cd65736b44153761b929de1c4387cb70
 * keywords:   => posets
 * reviewer:   => Travis Scrimshaw, Anne Schilling


Comment:

 The current branch fixes the bug. The rationale is to allow posets to not
 have a specified linear extension. This is achieved by changing the input
 behavior of `FinitePoset`. If `elements` is specified, this is used for
 the underlying linear extension. If `elements` is None, then the default
 linear extension is now computed in the `__init__`, so that posets where
 linear extensions are not specified now compare equal.

 Travis and Anne
 ----
 Last 10 new commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=691807bd10ca2f1fd6351ce5e4460ac08027e0fa
 691807b]||{{{Fixed issues with relabeling and elements. Fixed some
 doctests.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d5c570c6960045b77db891bd08de0bc78fc706c0
 d5c570c]||{{{Some more fixes.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=a1eca30f4845675ac76613852357787b6576cf3f
 a1eca30]||{{{reinstated linear_extension}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=95f735bfc9dd5f054867448c6c0f7a40688a2496
 95f735b]||{{{getting the interface right!}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=01dc92d22e2a323b4d66d0b8e80d1c9738ca663c
 01dc92d]||{{{needed one more relabelling for correct linear
 extensions}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f1511c0ded4cd1e7ca852d5ff4cb29dd69796cdd
 f1511c0]||{{{Fixing bugs in relabeling by not doing it automatically in
 __classcall__.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=6f86a9a0b2fe4f4d75e9407b9b6b8bde2664c0fd
 6f86a9a]||{{{fixed some docs}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c7e710738c8e451f103dc2bb25b72e609452a0dd
 c7e7107]||{{{Fixed last issues. All doctests pass.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=ed7f0910616d397db2320bfcb0994f6ae4f0e5b8
 ed7f091]||{{{more doc test fixes}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=b1eefd78cd65736b44153761b929de1c4387cb70
 b1eefd7]||{{{Some more documentation as reference.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to