#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Travis Scrimshaw,  |    Reviewers:  Travis Scrimshaw,
  Anne Schilling                     |  Anne Schilling
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/poset/fix_equality-14019|  
e575742951572b4b383abeae1e21e934b9e1683f
   Dependencies:  #17059             |     Stopgaps:  #14185
-------------------------------------+-------------------------------------

Comment (by aschilling):

 Replying to [comment:43 ncohen]:
 > Positive review ? On my computer this code breaks a *LOT* of doctests in
 the combinat folder.

 They were all trivial failures and are fixed now!

 >Also, I do not understand what you do in the .dual() function. You seem
 to define a >elements variable that you do not use. As a result the dual
 of a Poset with a linear >extension becomes a poset without linear
 extension.

 Fixed.

 >Would it also be possible to change the __repr__ function so that is says
 explicitly
 >that the poset is a poset with a linear extension ? The two posets behave
 as if they
 >were of different type (they can never be equal), and if such a poset is
 returned by a
 >function it may surprise the user that the poset is never equal to a
 poset he built
 >himself.

 If this is only for HIM, I am sure this is now in your ability range to
 fix it, if it is important to you!

 Anne

--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to