#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: posets | Merged in:
Authors: Travis Scrimshaw, | Reviewers: Travis Scrimshaw,
Anne Schilling | Anne Schilling
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/poset/fix_equality-14019|
c5c6a0c6c0cc48a2ce6a89652aaccb48b35b987a
Dependencies: #17059 | Stopgaps: #14185
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello,
Besides Jori's report, I have one question. Why did you do this change ?
{{{
#!diff
- G = DiGraph(self._hasse_diagram).relabel(self._list,
inplace=False)
+ G = DiGraph(self._hasse_diagram).relabel(self._elements,
inplace=False)
}}}
Did the meaning of `self._list` changed in some way ? If it did, this
function probably isn't the only one that needs to be updated `O_o`
More importantly: aren't `self._list` and `self._elements` the same thing
? It would be nice in a later patch to change this name is something like
`linear_extension`, for it really is a pain to work with this class when
variables are not named according to what they represent. And perhaps one
day it will become trustworthy `:-P`
Thanks,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:76>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
