#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: posets | Merged in:
Authors: Travis Scrimshaw, | Reviewers: Travis Scrimshaw,
Anne Schilling | Anne Schilling
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/poset/fix_equality-14019|
c5c6a0c6c0cc48a2ce6a89652aaccb48b35b987a
Dependencies: #17059 | Stopgaps: #14185
-------------------------------------+-------------------------------------
Comment (by aschilling):
Replying to [comment:79 ncohen]:
> > No, `self._list` are wrapped elements (if not a facade), whereas
`self._elements` are always the unwrapped elements, and we always want to
label the digraph by the unwrapped elements.
>
> Okay. Do you have any objections if later the following variables are
renamed
>
> - `_list` -> `_linear_extension_of_wrapped_elements`
> - `_elements` -> `_linear_extension_of_unwrapped_elements`
>
> By the way, what would you think in this ticket of renaming the
`linear_extension` parameter you added ? The name does not sound at all
like it is a boolean variable, and you create a `Poset._linear_extension`
variable which is boolean. If you renamed it to
`Poset._carries_linear_extension` or something (whose name sounds like a
boolean variable) we could rename `_list` to `_linear_extension` and
`_elements` to `_linear_extension_unwrapped_elements` (which I think is
better/shorter).
>
> The thing is that if we have to rename `linear_extension` later we will
have to deprecate it --> loss of time.
>
> Nathann
Go ahead and write a review patch which makes these changes!
Anne
--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:80>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
