#14019: equality is broken for Posets
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:  sage-combinat
           Type:  defect             |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Travis Scrimshaw,  |    Reviewers:  Travis Scrimshaw,
  Anne Schilling                     |  Anne Schilling
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/combinat/poset/fix_equality-14019|  
aa1cc73510663efb9552f12dd432109c8fd0d20d
   Dependencies:  #17059             |     Stopgaps:  #14185
-------------------------------------+-------------------------------------

Comment (by aschilling):

 There were two more doc test failures in `combinat/ordered_trees.py` due
 to the non-canonical way of labeling the vertices in `canonical_label`. I
 fixed those. Everything else looks ok to me.

 >However the labeling itself is not unique. Consider the path on 3
 vertices with
 >labelings 0 - 1 - 2 and 1 - 0 - 2. The first one is no more canonical
 than the second.

 Precisely!

 John: if you are happy now, can we set it back to positive review?

 Nathann: if you are still unhappy, please change the behavior in a
 different ticket. In this ticket we wanted to keep the behavior of the
 posets with `_linear_extension = True` as previous.

--
Ticket URL: <http://trac.sagemath.org/ticket/14019#comment:70>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to