#17186: LatticePoset: faster is_modular
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__faster_is_modular|
c2a4f3485cb5981f21a25faa9c1acc6e4379615c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> I don't have physical book, this was on http://www-
math.mit.edu/~rstan/ec/ec1.pdf
Okay.
> Definition says "for all ... => ...", and my code converts this to "if
... < ... return False". Should I convert this to "return all(... for a
in... for b in...)"?
I see. Sorry for that.
> Changing rank_dict to array would need changing some parts of
`hasse_diagram.py`.
It is weird that it got implemented like that in the first place. There is
some speed to get for free there.
Anyway. I will review that patch in a second.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17186#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
