#17186: LatticePoset: faster is_modular
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__faster_is_modular|
3ca400619ffcac9c7bdb5f045f1b0d656fc32bf3
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yooooooo !
> Arghs, of course. Corrected `is_graded` -> `is_ranked`.
>
> Same change should be made for `is_distributive()`. Or actually,
`lattices.py` should define it's own `is_graded` and save thousands of
picoseconds.
Hmmm... But then I wonder: when did you observe a difference in speed ?
When you changed the formulation used in the loop (which makes sense) or
when you changed graded to ranked (which would be alarming) ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17186#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
