#17186: LatticePoset: faster is_modular
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__faster_is_modular|
179772f44608c7984e42fc90e52d28fe08f6f2b5
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> There was a minor error, `is_ranked` should be `is_graded`.
Isn't it exactly the same for lattices ?
> Also there is now some other minor changes.
Hmmm... Well, take a look at commit "Correction from is_ranked to
is_graded; some changes on docs". You will see what is the effect of
changing the order in which the functions appear for the reviewer `:-P`
> I'm not happy with examples, but at least the code is now much faster.
Well, it seems good to me (even though the examples were weak from the
start) but I would like to have your opinion on this ranked/graded thing
first, because I do not understand how it could make your code faster if
the two are equivalent `O_o`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17186#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
