#15820: Implement sequences of bounded integers
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: algebra | Resolution:
Keywords: sequence bounded | Merged in:
integer | Reviewers:
Authors: Simon King, | Work issues:
Jeroen Demeyer | Commit:
Report Upstream: N/A | d22c1ca23727402e376c7f772c2f51b8ed6af1f1
Branch: | Stopgaps:
u/jdemeyer/ticket/15820 |
Dependencies: #17195, #17196 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Perhaps we should consider to change the hash function for bitsets (see
the comments for the hash of bounded integer sequences that you removed).
But I suppose this should not be done on this ticket.
My summary:
- We have different functions that assume that the given sequences have
equivalent bounds. In most cases, the assumption is not checked, with
exception of the one assert that you introduced. I vote for removing the
assert.
- I don't think iteration should use `biseq_getitem` to extract items one
by one. Instead, the current idea ("shift enough data so that one limb is
full and extract items from this single limb") should be preserved.
- I like your change to `biseq_getitem`, where you avoid using
`mpn_rshift` for just one/two limbs. I think the same change could be done
in `biseq_slice` in the case `step!=1`, and also in iteration.
Other than that, your changes seem fine to me. I suggest to do the
"replacement of one/two limb shifts", unless you beat me to it.
--
Ticket URL: <http://trac.sagemath.org/ticket/15820#comment:263>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
