#17216: Poset / LatticePoset: [meet|join]matrix algorithm
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/poset___latticeposet___meet_join_matrix_algorithm|
a7d2dd08623026a269f5fd7700b9e659985e7579
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Hello !
Thanks you for this branch, it is nice code.
A couple of comments and it can go:
1) The tests do not pass in the combinat/poset/ folder.
2) The code of `_join` would be simpled if you called "min(T)" instead of
relabelling all points as `n-1-y`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17216#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
