#17216: Poset / LatticePoset: [meet|join]matrix algorithm
-------------------------------------+-------------------------------------
       Reporter:  jmantysalo         |        Owner:
           Type:  enhancement        |       Status:  needs_info
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/poset___latticeposet___meet_join_matrix_algorithm|  
a649be931b249028ff1e5961fc948c2daf50c695
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  positive_review => needs_info


Comment:

 Has anyone checked that we do get speedups in meet/join matrix?

 For the definition of a lattice, I've also been told you want a ''unique''
 meet and join. Otherwise just the existence is something like regular
 poset, sorry I forget the exact term right now.

 Also could you make the very minor change:
 {{{#!diff
 -        return matrix(ZZ, [[n-1-join[n-1-x][n-1-y] for y in range(n)] for
 -                           x in range(n)])
 +        return matrix(ZZ, [[n-1-join[n-1-x][n-1-y] for y in range(n)]
 +                           for x in range(n)])
 }}}
 IMO it makes the code easier to read, but feel free to disregard.

--
Ticket URL: <http://trac.sagemath.org/ticket/17216#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to