#16954: Game Theory: Build class for normal form games as well as ability to 
obtain
Nash equilibria
-------------------------------------+-------------------------------------
       Reporter:  vinceknight        |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.4
      Component:  game theory        |   Resolution:
       Keywords:  Game Theory,       |    Merged in:
  Normal Form Games                  |    Reviewers:  Karl-Dieter Crisman
        Authors:  Vince Knight,      |  Work issues:
  James Campbell                     |       Commit:
Report Upstream:  N/A                |  9e14ff21121029f311b53d608b6a6d826ff2af88
         Branch:                     |     Stopgaps:
  u/vinceknight/finishedresponsetobigreview|
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by kcrisman):

 I don't think I'll get to everything in one comment, but assume that if I
 don't mention it it's either okay or I'm still getting to it.

 ----
 > > Parser comments.
 > >  * Minor - this could be made slightly more professional-sounding.
 Also, double ticks for code markup; maybe even {{{``'lrs'``}}} if it is a
 string, I'm not sure about this.
 > > {{{
 > >     At present the only parser included is the for `lrs` algorithm
 however
 > >     this will be expanded to `gambit` soon.
 > > }}}
 >
 > Have changed wording and also ticks but I'm not sure if it's quite what
 you meant.

 No.  What you changed it to is
 {{{
 #!diff
 -    At present the only parser included is for 'lrs' algorithm however
 -    this is actively being expanded to 'gambit'.
 +    At present the only parser included is for `lrs` algorithm however
 +    this is actively being expanded to `gambit`.
 }}}
 but what we need is for {{{`lrs`}}} or the previous {{{'lrs'}}} to become
 {{{``'lrs'``}}}.  Notice the double backticks (typeset as code) and the
 single quote because, well, it needs single quotes because it's a string
 (such as in the example {{{sage:
 matching_pennies.obtain_Nash(algorithm='lrs')}}}).  That said, it probably
 can be kept {{{'lrs'}}} in some contexts, I think it's just especially
 important in places like
 {{{
     1. ``lrs`` (requires lrs)
     2. ``enumeration``
 }}}
 where not having the quotes could mean people will type in something nasty
 and wrong.

 ----

 Here is a dumb comment - you have {{{between gambit and sage.}}} but then
 it should be {{{Sage}}}.  Trivial, I know, I apologize but I just happened
 to see it.

 > >  * `        LaTeX method shows nothing interesting for games with more
 players::` - then you should probably use the `...` like so:
 > > {{{
 > > \text{\texttt{<bound{ }method{ }NormalFormGame...[False,{ }False,{
 }False]{\char`\}}>}}
 > > }}}
 > >    or the like.
 >
 > Have gone with your suggestion.

 Yikes!  I see now I was assuming too much information.  What I meant by
 that is that the LaTeX method is fine, but that in ''doctesting'' it one
 can use three periods in a row to substitute for arbitrary sequences.  So
 keep the original LaTeX method, but add ... in the middle of it so that
 the doctest is actually legible and it's clear what it's testing for.

 ----
 More to come.

--
Ticket URL: <http://trac.sagemath.org/ticket/16954#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to