#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers: Karl-Dieter Crisman,
Authors: Vince Knight, | Travis Scrimshaw
James Campbell | Work issues:
Report Upstream: N/A | Commit:
Branch: | 27730d02de114bf1ea38f5b9a099198301fdd188
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vinceknight):
Replying to [comment:94 tscrim]:
> Don't remove the `__eq__`. If you do, you can create equal games (i.e.,
the same input data) but won't compare equal in Sage. In particular, if
you do `loads(dumps(x)) == x` (pickling) for some game `x`, then it will
return `False` because the default (python) `==` is by identity (place in
memory).
>
> Addendum - The comparison isn't sufficient. Actually, from a quick
glance, it's the `Player` equality testing that is not sufficient and
probably needs to compare the `Player.pref`'s.
Cool, never intended to remove `__eq__`, just needed to check that it
wasn't coded the way it was for a reason. Was saying that I could remove
the test that now doesn't pass but instead will now focus on fixing the
code so that the test passes: will work on the `Player` equality: thanks!
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:95>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
