#16331: Game Theory: Build capacity to solve matching games in to Sage.
-------------------------------------+-------------------------------------
Reporter: vinceknight | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.4
Component: game theory | Resolution:
Keywords: Game Theory, | Merged in:
Matching Games, | Reviewers: Karl-Dieter Crisman,
Authors: Vince Knight, | Travis Scrimshaw
James Campbell | Work issues:
Report Upstream: N/A | Commit:
Branch: | fa2e5c1e380c6c42125e69748dcd3f8c71a6ef1d
u/vinceknight/game_theory__build_capacity_to_solve_matching_games_in_to_sage_|
Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by kcrisman):
Hmm, I don't feel terribly strongly about this per se, but if it causes
things to be equal that shouldn't, that's a problem. How is the
`loads(dumps(x)) == x` holding up with this? Maybe one needs to have a
warning of player equality being only name equality in that function's
doc, anyway.
As to the substantive change, I still am not happy. For equality, you
only check if the sets of players are the same
{{{
and set(self._suitors) == set(other._suitors)
and set(self._reviewers) == set(other._reviewers)
}}}
but not whether their ordering is the same, but then check for the order
(implicitly) here.
{{{
+ and all(r1.pref == r2.pref for r1, r2 in
+ zip(self._reviewers, other._reviewers))
+ and all(s1.pref == s2.pref for s1, s2 in
+ zip(self._suitors, other._suitors)))
}}}
What about if the players are swapped? Is it now a different game? I
don't know what the 'right' answer is but if the order matters, then it
probably matters for the players too. Plus it would end the comparison
earlier - as soon as one `and` is `False`, it all is.
--
Ticket URL: <http://trac.sagemath.org/ticket/16331#comment:99>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
