#17385: Cleanup Graph.__init__ and DiGraph.__init__
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.5
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: David Coudert
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/17385 | 3f8a98bc9caa9f64504cf2d85ce4ed39ea7ce12c
Dependencies: #17384 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Thanks for the review.
To answer your interrogation `is` and `==` are '''very''' different, and
`is` will '''always''' be faster.
The command `bool is False` is treated without asking anything to the
object `bool`. It is just the Python kernel that checks whether the memory
addresses match or not. For `==` a method of the object `bool` is called.
Even if the comparison is implemented with something like `return self is
other` you do not avoid that function call.
But I am not sure that those 18 non seconds are of critical importance in
the creation of a graph... it was more a matter of uniformization ;-)
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/17385#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
