#17385: Cleanup Graph.__init__ and DiGraph.__init__
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.5
      Component:  graph theory       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:  David Coudert
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/17385                 |  0fa9c20b5cf44989b40726e5c740c82a564a5263
   Dependencies:  #17384             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by dcoudert):

 I don't understand why you write
 {{{
 if not loops and any(u in neighb for u,neighb in data.iteritems()):
    if loops is False:
 }}}
 Obviously, if the first test is True, then we have {{{loops==False}}}. So
 you don't need the second one.

 The same holds for {{{if not weighted and any(...): if weighted is
 False:}}} and {{{if not multiedges and any(...): if multiedges is
 False:}}} and ...

--
Ticket URL: <http://trac.sagemath.org/ticket/17385#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to